docs: correct testing documentation and commands; clean legacy references#95
Open
mikemaccana wants to merge 1 commit into
Open
docs: correct testing documentation and commands; clean legacy references#95mikemaccana wants to merge 1 commit into
mikemaccana wants to merge 1 commit into
Conversation
ae3e0b9 to
7c0c562
Compare
…an legacy references - Standardize Anchor testing instructions on one command: `anchor test`. - Remove alternative `cargo test` suggestions from CONTRIBUTING.md and Anchor READMEs (counter, hello-solana, close-account, transfer-sol, rent, realloc, token-swap, transfer-tokens, create-token, program-derived-addresses, etc.). - Update root README framework description and getting-started text for consistency. - Remove ACTIVE-AUDIT-ITEMS.md from this PR (per request). - Preserve contributor credits in Pinocchio examples (e.g. @MarkFeder ports from solana-developers/program-examples) while cleaning other stale references. Co-authored-by: Cursor <cursoragent@cursor.com>
7c0c562 to
f8dbbc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR executes three focused items from the solana-program-examples audit vs. the latest solana-finance skill (https://github.com/quicknode/solana-finance-skill):
Fix testing documentation and commands: CONTRIBUTING.md, root README, and many anchor example READMEs now correctly document the actual commands and layout.
anchor test(orcargo test) from the.../anchor/dir. Tests live inprograms/<name>/tests/.cargo test(orquasar test). Tests live insrc/tests.rs(per Quasar.toml).pnpm testfrom the subdir" guidance and fixed prerequisite text.Enforce transfer_checked uniformly in Quasar token paths (documentation + prep): Investigation confirmed
quasar_spl.transfer(...)is the raw/unchecked form while.transfer_checked(..., mint, ..., decimals)is the safe equivalent (already used correctly in lending and external-delegate Quasar code).ACTIVE-AUDIT-ITEMS.md.transfer_checked.Clean legacy / inconsistent artifacts (markdown portion): Removed active references and links to the deprecated
solana-developers/program-examples(and professional-education) in credits and docs per the skill rules.ACTIVE-AUDIT-ITEMS.mdcontains the exact steps + commands for deleting the orphantokens/.../allow-block-list-token/anchor/tests-rs/directory and stripping stale bankrun/validator comments from a few Anchor.toml files.All landed changes are documentation / reference cleanup. The
ACTIVE-AUDIT-ITEMS.mdfile committed with the PR serves as the detailed record and patch source for the remaining non-markdown parts of the three items.Changes
Test plan
basics/counter/anchor,finance/token-swap/anchor,basics/hello-solana/anchor):anchor build && anchor test(or plaincargo test).cargo test.ACTIVE-AUDIT-ITEMS.md: run the relevantcargo test(Quasar finance) andanchor testfor any touched tomls.pnpm check/pnpm lint(biome) at repo level if desired.✅ Testing docs/commands aligned
✅ Legacy references cleaned (markdown)
❌ (Prepared) Quasar transfer_checked source changes + orphan dir + toml comments — patches + exact commands in ACTIVE-AUDIT-ITEMS.md
Made with Cursor